]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
pointerA11yTimeout: Don't stop the pie timer if it finished successfully
authorJonas Dreßler <verdre@v0yd.nl>
Thu, 22 Aug 2019 08:10:23 +0000 (10:10 +0200)
committerOlivier Fourdan <ofourdan@redhat.com>
Tue, 27 Aug 2019 08:03:49 +0000 (08:03 +0000)
If the pie timeout has finished successfully there's no need to cancel
the pie animation, instead we can just wait for that animation to finish
and show some visual feedback like a zoom-out animation to indicate the
click afterwards.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/688

js/ui/pointerA11yTimeout.js

index 0546f1de4b467665ea241bc2502ee3d096e8951e..5744ac300d053146bea7086b1ed47882236f6ca0 100644 (file)
@@ -110,8 +110,10 @@ var PointerA11yTimeout = class PointerA11yTimeout {
                 global.display.set_cursor(Meta.Cursor.CROSSHAIR);
         });
 
-        manager.connect('ptr-a11y-timeout-stopped', (manager, device, type) => {
-            pieTimer.stop();
+        manager.connect('ptr-a11y-timeout-stopped', (manager, device, type, clicked) => {
+            if (!clicked)
+                pieTimer.stop();
+
             if (type == Clutter.PointerA11yTimeoutType.GESTURE)
                 global.display.set_cursor(Meta.Cursor.DEFAULT);
         });